[coreboot-gerrit] [L] Change in coreboot[master]: util/amdfwtool: Deal with psp position in flash offset directly

[Christopher Meis (Code Review)]

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Arthur Heymans, Martin Roth, Fred Reitberger, Marvin Drees, Karthik Ramasubramanian, Felix Held.

Christopher Meis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )

Change subject: util/amdfwtool: Deal with psp position in flash offset directly
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/69852/comment/07d626a7_e428dc82 
PS4, Line 25: $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 1 $(CONFIG_AMD_FWM_POSITION))
> This also is not exactly correct.
>
> When looking for the EFS location, the PSP only cares about flash offsets.
> In EFT, again, addresses to PSP and BIOS directories are set in flash offsets.
>
> PSP and BIOS directory headers have a indicator to provide information about address mode to expect from each entry. Entries inherit this information if not overwritten by entry configuration from the outside/user.

Addition:
This is also true, when placing the EFT and/or binaries in upper/lower flash if ROM is larger than 16Mb.

Note: I observed serveral aspects of the documentation as invalid, untrue, unspecific and/or mutual exclusive. Stuff which might work for servers do not work for client platform and vice versa.

Basically everything can be right or wrong at the same time, depending on the platform we're talking about.