Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790 ......................................................................
Patch Set 61:
(6 comments)
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/variants/optiplex_790_mt-sff/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 31: 0x0
0
Done
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 37: 0x0
0
Done
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/variants/optiplex_790_usff/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 14: : register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" : register "gfx.link_frequency_270_mhz" = "0" : register "gfx.ndid" = "3"
This can be dropped
Done
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 21: 0x0
0
Done
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 29: 0x0
0
Done
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 35: 0x0
0
Done