[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

PS12:
> PCH terminology typically doesn't exist for atom line. […]

Even if an IP block is not used by a particular family, it should be part of common/block and the SoC can decide whether or not that block is present on the SoC which is controlled by the Kconfig. Isn't that right?