Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36455 )
Change subject: soc/intel/{apl,cnl,dnv,icl,skl}: Move lpc.asl into common/block/acpi
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36455/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/lpc.asl:
https://review.coreboot.org/c/coreboot/+/36455/6/src/soc/intel/common/block/...
PS6, Line 20:
Curious about some of the legacy devices here:
1. There is a forbidden list that Linux kernel maintains https://github.com/torvalds/linux/blob/master/drivers/acpi/acpi_platform.c#L.... Does it mean that these should not be exposed by the BIOS?
2. There are some HIDs that are not enumerated at all by the kernel. Are these added because they are used by other OSes?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I266d6e667e7ae794377e4882791e3be933d35e87
Gerrit-Change-Number: 36455
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 01 Nov 2019 06:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment