Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34497 )
Change subject: mb/google/drallion: Add new mainboard
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34497/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34497/10//COMMIT_MSG@13
PS10, Line 13: BUG=None
: Test=Needs to be tested
were these not correct in the last patch?
BUG=b:138098572
TEST=compiles
https://review.coreboot.org/c/coreboot/+/34497/9/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34497/9/src/mainboard/google/dralli...
PS9, Line 210: "MISCCFG_GPSIDEDPCGEN | MISCCFG_GPRTCDLCGEN | MISCCFG_GSXSLCGEN | MISCCFG_GPDPCGEN | MISCCFG_GPDLCGEN"
Done! […]
Sure, that'll work. Thanks much.
https://review.coreboot.org/c/coreboot/+/34497/9/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/34497/9/src/mainboard/google/dralli...
PS9, Line 21: const u32 cim_verb_data[] = {
Could you help confirm verb table? I always get audio init timeout in depthcharge... […]
EricR, would you be ok if that was handled in a follow-on patch, or does it need to be done in the initial commit?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I541952a4ef337e7277a85f02d25979f12ec075c4
Gerrit-Change-Number: 34497
Gerrit-PatchSet: 10
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 02 Aug 2019 16:11:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thejaswani Putta
thejaswani.putta@intel.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment