build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18902 )
Change subject: util/intelvbttool: Rewrite tool ......................................................................
Patch Set 13:
(8 comments)
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c File util/intelvbttool/intelvbttool.c:
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@42... PS13, Line 421: struct fileobject* fo = malloc_fo(size); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@77... PS13, Line 773: (const struct vbt_header *)fo->data; code indent should use tabs where possible
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@80... PS13, Line 808: /* Duplicate fo as caller is owner of fo and remalloc frees the object */ line over 80 characters
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@84... PS13, Line 845: if (oh->size == 0 || oh->size > 0x80|| oh->size * 512 > fo->size) { spaces required around that '||' (ctx:VxW)
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@85... PS13, Line 855: } else { else is not generally useful after a break or return
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@86... PS13, Line 867: pcir = (const optionrom_pcir_t *)((const u8 *)oh + oh->pcir_offset); line over 80 characters
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@92... PS13, Line 924: const struct fileobject* fo_vbt = malloc_fo_sub(fo, i); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@96... PS13, Line 964: bdb = (const struct bdb_header *)((const char *)head + head->bdb_offset); line over 80 characters