Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41443/5/src/device/resource_allocat... File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/5/src/device/resource_allocat... PS5, Line 217: memranges_init_empty_with_alignment For reviewers:
This has changed since the original CL was pushed. Earlier it used memranges_init_empty() which uses alignment of 12 i.e. 4KiB. But that is required only for IORESOURCE_MEM and not for IORESOURCE_IO. Hence, get_alignment_by_resource_type() returns the correct alignment to be used when initializing memranges.
https://review.coreboot.org/c/coreboot/+/41443/5/src/device/resource_allocat... PS5, Line 358: avoid_fixed_resources For reviewers:
This is different than the original CL that was pushed. Initially this function used search_bus_resources(). But, that does not really walk down the entire tree and also domain fixed resources were not being considered. Thus, avoid_fixed_resources() is added to consider fixed resources in the entire tree.