Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48645 )
Change subject: soc/amd/cezanne: Add SMI support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48645/7/src/soc/amd/cezanne/include...
File src/soc/amd/cezanne/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/48645/7/src/soc/amd/cezanne/include...
PS7, Line 9: 58
The number is from 0 to 58. […]
ok, that part of the code is unexpected. it would be good to change that behavior in a follow-up patch, but at least the code is doing the right thing at the moment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83b9a91cbab297d032292997a4d5768b89fe97dd
Gerrit-Change-Number: 48645
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Dec 2020 17:20:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment