29 Jul
2020
29 Jul
'20
7:43 a.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43988 )
Change subject: Update dq/dqs mappings ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/memory.c:
https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee... PS2, Line 10: { 3, 0, 1, 5, 4, 7, 6, 2 }, /* DDR0_DQ1[7:0] */
nit: align all the comments
Ack
https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee... PS2, Line 57: const struct lpddr4x_cfg *(void)
function name is missing : variant_memory_params
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/43988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98f79283aa18f6fd41114fb6b60cac1cbed69de7
Gerrit-Change-Number: 43988
Gerrit-PatchSet: 4
Gerrit-Owner: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Jul 2020 05:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment