[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cnl: Enable VT-d

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32432 )

Change subject: soc/intel/cnl: Enable VT-d
......................................................................

Patch Set 3:

(1 comment)
> Enable by default will be okay? Or we can still disable that by default and leave mainboard to decide that's enabled or disabled?

I would prefer to enable it and not to have an option
at all until somebody asks for an option to disable it.
Or does anybody already want to disable it?

IMHO, the `VtdDisable` in `chip.h` should be (re)moved
anyway: It's not a mainboard question but a question of
the coreboot build and, thus, belongs into Kconfig.

https://review.coreboot.org/#/c/32432/3/src/soc/intel/cannonlake/acpi.c 
File src/soc/intel/cannonlake/acpi.c:

https://review.coreboot.org/#/c/32432/3/src/soc/intel/cannonlake/acpi.c@364 
PS3, Line 364: any platform initiated DMA
             : 	 * is restricted
It says "is restricted" and, AFAIUI, it would only be restricted
if we actually set up the respective page-tables + configure and
enable the IOMMU.