Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38826 )
Change subject: mb/google/hatch: Create nightfury variant ......................................................................
Patch Set 44: Code-Review+1
(19 comments)
Patch Set 44:
Raymond, please click on 'resolve' for all pending comments. Thanks.
Hi Philip,
We have finished.
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG@2 PS1, Line 2: raymondchung
ok
Done
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG@7 PS1, Line 7: /mb/google/hatch: Create nightfury variant
ok
Done
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG@9 PS1, Line 9: Create new variant for nightfury
According to the needs of issue 149226871. […]
Done
https://review.coreboot.org/c/coreboot/+/38826/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38826/3//COMMIT_MSG@9 PS3, Line 9: Create new variant for nightfury
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/24/src/mainboard/google/hatch... File src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex:
https://review.coreboot.org/c/coreboot/+/38826/24/src/mainboard/google/hatch... PS24, Line 1: 24 20 0F 0E 15 19 01 08 00 00 00 0B 03 03 00 00
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... PS10, Line 3: 2019
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/gpio.c:
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... PS10, Line 4: 2019
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... PS10, Line 4: 2019
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... PS10, Line 4: 2019
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... PS10, Line 4: 2019
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/38/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/memory.c:
https://review.coreboot.org/c/coreboot/+/38826/38/src/mainboard/google/hatch... PS38, Line 4: 2018
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/38/src/mainboard/google/hatch... PS38, Line 4: (C)
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... PS3, Line 7: : [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
I think it is another CML-based Samsung device, which is a better reference in this case.
Done
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... PS3, Line 11: [PchSerialIoIndexI2C5] = PchSerialIoPci,
I think it is another CML-based Samsung device, which is a better reference in this case.
Done
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... PS3, Line 53: .i2c[3] = { : .speed = I2C_SPEED_FAST, : },
I think it is another CML-based Samsung device, which is a better reference in this case.
Done
https://review.coreboot.org/c/coreboot/+/38826/15/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38826/15/src/mainboard/google/hatch... PS15, Line 53: .i2c[3] = { : .speed = I2C_SPEED_FAST, : },
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38826/1/src/mainboard/google/hatch/... PS1, Line 27: Kohaku
Sorry! It is not correct. The correct name is nightfury.
Done
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38826/10/src/mainboard/google/hatch... PS10, Line 4: 2019
Done
Done
https://review.coreboot.org/c/coreboot/+/38826/43/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38826/43/src/mainboard/google/hatch... PS43, Line 29: gpio_output(GPP_C11, 1); : mdelay(1); : gpio_output(GPP_A12, 1);
- This code can be removed. […]
Done