[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency

[Nico Huber (Code Review)]

Attention is currently required from: Bora Guvendik, Hannah Williams, Subrata Banik, Jérémy Compostella, Paul Menzel.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74141 )

Change subject: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency
......................................................................

Patch Set 5:

(1 comment)

File src/soc/intel/common/block/pcie/pcie.c:

https://review.coreboot.org/c/coreboot/+/74141/comment/44047722_164bd1c6 
PS4, Line 14: __weak
> > I could not find a document, but there are discussions on Gerrit. […]

We usually use Kconfig for such overrides. Now that we have chipset
devicetrees, a devicetree setting would also be possible (unless 0 is
a valid value, then it would be inconvenient).

In about 90% of the cases I see a weak function, it only seems handy
because something else is already off. In this case even adding a
function, not to mention a weak one, looks odd to me.