Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41471 )
Change subject: soc/intel/broadwell: Mask lower 20 bits of TOLUD and TOLM in systemagent.asl ......................................................................
Patch Set 6:
Patch Set 6:
Why was this not fixed in the whole tree?
Was any platform missed? I had done a grep for TLUD in *.asl files:
# git grep -l TOLUD *.asl src/northbridge/intel/gm45/acpi/hostbridge.asl src/northbridge/intel/i945/acpi/hostbridge.asl src/northbridge/intel/pineview/acpi/hostbridge.asl src/northbridge/intel/x4x/acpi/hostbridge.asl src/soc/intel/apollolake/acpi/northbridge.asl src/soc/intel/broadwell/acpi/systemagent.asl src/soc/intel/common/block/acpi/acpi/northbridge.asl src/soc/intel/skylake/acpi/systemagent.asl
Out of these northbridge/intel seem to handle the TOLUD in a very different way where they refer to only the address bits in TOLUD. Hence, no masking required.
apollolake was already doing the right thing.
I pushed changes for broadwell, skylake and intel/common.
Were there more platforms that required changes?