24 Nov
2019
24 Nov
'19
5:24 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
Patch Set 1: Code-Review+2
At least lumpy needs additional debug hardware on it's LPC connector to have SUPERIO. The default is wrong here, these boards should select NO_UART_ON_SUPERIO?
config DRIVERS_UART_8250IO # FIXME: Shouldn't have a prompt, should default to n, and # should be selected by boards that have it instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0eda4aee2cbb114bde33e862940a64675469693d
Gerrit-Change-Number: 37183
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Nov 2019 01:24:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment