Attention is currently required from: Christian Walter, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58879 )
Change subject: mb/prodrive/hermes: Configure pink rear vref based on eeprom ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/58879/comment/d171d708_273a1e66 PS1, Line 60: F nit: lowercase `f`
https://review.coreboot.org/c/coreboot/+/58879/comment/bf75b8f0_23fab9ba PS1, Line 82: const u32 internal_config = get_internal_audio_cfg(board_cfg->internal_audio_connection);
line over 96 characters
Please fix. Simply rename the constant to `internal_cfg`.
https://review.coreboot.org/c/coreboot/+/58879/comment/1f5e009a_efc75053 PS1, Line 83: pink_config nit: Also rename this to `pink_cfg` for consistency.
https://review.coreboot.org/c/coreboot/+/58879/comment/4631b1c6_bd0071a9 PS1, Line 89: get_port_c_vref_cfg(board_cfg->blue_rear_vref), Hmmm, this one is probably wrong then