Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes
......................................................................
Patch Set 2:
Patch Set 2:
We can move these GNVS prototypes to x86/smm.h or arch/acpi.h ?
One needs a typedef for global_nvs_t for that work, and that creates a dependency on chipset headers (where should they be? here we have soc/ and southbridge/ paths) where we would need consistent names and #include path to pull it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36636
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8eac39e09d1c36044cb2e2a96edd5c7098b8259
Gerrit-Change-Number: 36636
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 Nov 2019 17:21:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment