Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44939 )
Change subject: mb/google/dedede/var/drawcia: Add MIPI camera support
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44939/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44939/8//COMMIT_MSG@10
PS8, Line 10: 2. add IPU/VCM/NVM/CAM1 in devicetree
Can you please mention it is WFC. I interpret it so, but is not clear.
https://review.coreboot.org/c/coreboot/+/44939/8//COMMIT_MSG@13
PS8, Line 13: grap
Nit: grap -> grab
https://review.coreboot.org/c/coreboot/+/44939/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44939/8/src/mainboard/google/dedede...
PS8, Line 233: register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)"
: register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)
In the initial static ACPI ASL file, there is no delay between turning on Power Enable GPIOs. Do we still need the delay?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96f2ef682dff851d7788c2b612765a92228ddf75
Gerrit-Change-Number: 44939
Gerrit-PatchSet: 8
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Matt Delco
delco@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 21:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment