Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62500 )
Change subject: cpu/x86/smm: Add weak SoC and mainboard init and exit methods
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Oops, forgot to uncheck the resolved box.
What do you mean?
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/62500/comment/89a2c50b_7087c2ad
PS3, Line 55: void smm_mainboard_early_init(void);
: void smm_mainboard_exit(void);
In the subsequent patchset, we use only SoC hooks. […]
Sure, we can add the mainboard methods later if we need them. I'll push up a new patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I946619cd62a974a98c575a92943b43ea639fc329
Gerrit-Change-Number: 62500
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Mar 2022 15:49:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment