Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31182 )
Change subject: usbdebug: Use fixed size field
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31182/2/src/drivers/usb/ehci_debug.c
File src/drivers/usb/ehci_debug.c:
https://review.coreboot.org/#/c/31182/2/src/drivers/usb/ehci_debug.c@a34
PS2, Line 34:
this includes an int?
https://review.coreboot.org/#/c/31182/2/src/drivers/usb/ehci_debug.c@a35
PS2, Line 35:
should be __packed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60382664a53650b225abc1f77c87ed4e121d429e
Gerrit-Change-Number: 31182
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Feb 2019 10:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment