Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence ......................................................................
Patch Set 7:
(2 comments)
Now that we are no longer using gpio_get_output function, we can abandon those CLs and remove the dependencies for this CL.
https://review.coreboot.org/c/coreboot/+/34188/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/6/src/mainboard/google/octopu... PS6, Line 97:
The previous comment mentioned about […]
Personal Opinion: Safe to put it back in the default state for non-LTE SKUs
https://review.coreboot.org/c/coreboot/+/34188/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/garg/variant.c:
https://review.coreboot.org/c/coreboot/+/34188/7/src/mainboard/google/octopu... PS7, Line 79: power_off_lte_module_if_exist Fix the indentation issue. May need an additional tab to match alignment with return statement.