Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )
Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
My initial thought is this might've been a typo (i.e. bug) instead of poor form.
If it's a bug, my preference is to fix it instead of removing the poor form. But I haven't had time to nose around to see where this originally came from, dig into what the DCT settings are doing, if the AMD source might've been corrected later, etc. I also note that on l.75 this code is already limited to ->Speed of 3 or 4.
I had originally proposed the typo idea here
https://review.coreboot.org/c/coreboot/+/33211
though we were unable to decide if it actually was a typo or not.