Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39940 )
Change subject: mb/google/auron: Convert variants to use override devicetree ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 34: device pci 1c.3 on end # PCIe Port #4 - WLAN (becomes RP2)
Ah, please mention it somewhere (e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/samus/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 29: Disable S0ix
I'd still keep it, as it hints that something was wrong when using S0ix
Done