Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44701 )
Change subject: soc/mediatek/mt8192: Do the dramc pinmux selection
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra...
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra...
PS2, Line 9: const
const static
Done
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra...
PS2, Line 42: MRR
Lower case function name
Done
https://review.coreboot.org/c/coreboot/+/44701/2/src/soc/mediatek/mt8192/dra...
PS2, Line 74: dqO1
dqo1 or dq_o1
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44701
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bc1971646a65db8eef5eb5223c919645c6e8ed9
Gerrit-Change-Number: 44701
Gerrit-PatchSet: 7
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 01:12:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment