Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Julius Werner, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59507 )
Change subject: soc/intel/alderlake: Inject CSE TS into timestamp_table
......................................................................
Patch Set 11:
(3 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/59507/comment/d89f4681_b1892544
PS11, Line 164: cse_get_telemetry_data();
if (CONFIG(SOC_INTEL_CSE_PERFORMANCE_TELEMETRY))
cse_get_telemetry_data();
You don't need that weak implementation above may be.
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59507/comment/40cb8d92_ffcf3296
PS11, Line 149: SOC_INTEL_CSE_PERFORMANCE_TELEMETRY
shouldn't we highlight as pre-cpu reset telemetry ?
https://review.coreboot.org/c/coreboot/+/59507/comment/e386d6df_24fbec94
PS11, Line 151: SOC_INTEL_CSE_LITE_SKU
are this feature only implemented for lite sku alone. for my knowledge
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcdbb69538ca2977cd97ce1ef9b211ff6510a3f8
Gerrit-Change-Number: 59507
Gerrit-PatchSet: 11
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 03 Feb 2022 08:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment