Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/35041/2/src/mainboard/google/hatch/...
PS2, Line 52: mainboard_get_mmc_dll
can't we have soc level function and below hardcoded value moved into chip.h configs to be filled from mainboard ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10
Gerrit-Change-Number: 35041
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Fri, 23 Aug 2019 08:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment