Attention is currently required from: Alexander Couzens, Nicolas Provost.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75992?usp=email )
Change subject: new port for Lenovo L420 laptop ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/lenovo/l420/Kconfig:
https://review.coreboot.org/c/coreboot/+/75992/comment/9dd22ef6_080fd675 : PS7, Line 17: select TPM This should probably be `MAINBOARD_HAS_TPM1`. Then it compiles without errors.
https://review.coreboot.org/c/coreboot/+/75992/comment/e78acf21_8a3e25ca : PS7, Line 5: select SYSTEM_TYPE_LAPTOP : select NORTHBRIDGE_INTEL_SANDYBRIDGE : select USE_NATIVE_RAMINIT : select SOUTHBRIDGE_INTEL_BD82X6X : select EC_QUANTA_IT8518 : select NO_UART_ON_SUPERIO : select BOARD_ROMSIZE_KB_4096 : select HAVE_ACPI_TABLES : select HAVE_OPTION_TABLE : select HAVE_CMOS_DEFAULT : select HAVE_ACPI_RESUME : select INTEL_INT15 : select TPM : select MEMORY_MAPPED_TPM : select MAINBOARD_HAS_LIBGFXINIT : select GFX_GMA_PANEL_1_ON_LVDS : select INTEL_GMA_HAVE_VBT : select SERIRQ_CONTINUOUS_MODE : s Please order the list alphabetically:
``` select BOARD_ROMSIZE_KB_4096 select EC_QUANTA_IT8518 select GFX_GMA_PANEL_1_ON_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_TPM1 select MEMORY_MAPPED_TPM select NO_UART_ON_SUPERIO select NORTHBRIDGE_INTEL_SANDYBRIDGE select REALTEK_8168_RESET select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_BD82X6X select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT ```
File src/mainboard/lenovo/l420/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75992/comment/69438e25_7593462b : PS7, Line 68: # Enable SATA ports 0 (HDD bay) & 1 (ODD bay) & 2 (mSATA) & : # 3 (eSATA) & 4 (dock) : register "sata_port_map" = "0x1f" : : # Set max SATA speed to 6.0 Gb/s : Move these under the SATA controller