Attention is currently required from: Felix Singer, Joel Linn, Matt DeVillier, Nicholas Chin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
Patch Set 5: Code-Review+2
(3 comments)
Patchset:
PS5:
LGTM
File Documentation/mainboard/hp/pro_3500_series_flash.jpg:
PS2:
I saved the images locally to AVIF and they are now <40kB. […]
Seems ok to me. Even if there'll be somebody who has trouble viewing it, that's
always a risk (there are even browsers that can't display images at all).
If there are no objections, I'll close this soon.
File src/mainboard/hp/pro_3500_series/led.c:
https://review.coreboot.org/c/coreboot/+/81368/comment/2ad4ed51_6646e933 :
PS5, Line 8: // Board has a dual color LED
Nit, it's preferred to use only one comment style (`//` or `/* */`) throughout a file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Linn
jl_coreboot@conductive.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Joel Linn
jl_coreboot@conductive.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sat, 13 Apr 2024 13:55:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joel Linn
jl_coreboot@conductive.de
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment