Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/{agesa,pi}/hudson/acpi/fch.asl: Fix 'Object cannot be accessed' ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/31554/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31554/3//COMMIT_MSG@7 PS3, Line 7: sb/amd/{agesa,pi}/hudson/acpi/fch.asl: Fix 'Object cannot be accessed' This is too long and if anybody would care about the full path, he can look it up. This prefix would be enough:
sb/amd/hudson/acpi:
Also, you are not "fixing" an error message, you are fixing code...
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/agesa/hudson/acp... File src/southbridge/amd/agesa/hudson/acpi/fch.asl:
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/agesa/hudson/acp... PS3, Line 178: // #include "acpi/AmdImc.asl" /* Hudson IMC function */ Please remove.
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/pi/hudson/acpi/f... File src/southbridge/amd/pi/hudson/acpi/fch.asl:
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/pi/hudson/acpi/f... PS3, Line 141: /* TODO: It is unstable. */ This may actually relate to the problem IASL sees. Maybe amend the comment "might be fixed by restructuring".
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/pi/hudson/acpi/f... PS3, Line 163: // #include "acpi/AmdImc.asl" /* Hudson IMC function */ Please remove.