Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39040 )
Change subject: soc/intel/tigerlake: add DDR4 mem configuration
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39040/4/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:
https://review.coreboot.org/c/coreboot/+/39040/4/src/soc/intel/tigerlake/inc...
PS4, Line 75: spd_addr_table
I am not 100% sure about this, I need to check with memory team. I will take an AR on this. […]
I don't see a reason why that would be any different than LPDDR4x memory type. You should be able to provide either SpdAddressTable or pointers to actual SPDs. Adding of SPDs to CBFS should not be any different here than what is done on previous platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3858cc56c838862fc61123c8b7dba11dbc40983c
Gerrit-Change-Number: 39040
Gerrit-PatchSet: 7
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Feb 2020 05:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment