Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: soc/intel: Add Intel Xeon Scalable Processor support ......................................................................
Patch Set 45:
(3 comments)
Thanks for the review!
https://review.coreboot.org/c/coreboot/+/38548/41/src/soc/intel/xeon_sp/boot... File src/soc/intel/xeon_sp/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38548/41/src/soc/intel/xeon_sp/boot... PS41, Line 33: .CodeRegionBase = (UINT32)(0x100000000ULL - CONFIG_CBFS_SIZE), : .CodeRegionLength = (UINT32)CONFIG_CBFS_SIZE,
I am going to push this change and move on!! Issue happens sporadically on 2S Tioga Pass Server wher […]
We are going to figure out why this preferred method degrades boot stability. A follow-up patch will be made accordingly.
https://review.coreboot.org/c/coreboot/+/38548/44/src/soc/intel/xeon_sp/soc_... File src/soc/intel/xeon_sp/soc_util.c:
https://review.coreboot.org/c/coreboot/+/38548/44/src/soc/intel/xeon_sp/soc_... PS44, Line 375: 127
hm this can't be right. […]
This function is for debug purpose. It is removed.
https://review.coreboot.org/c/coreboot/+/38548/44/src/soc/intel/xeon_sp/soc_... PS44, Line 361: switch (maxbusno) { : case 0: : printk(BIOS_DEBUG, "Max Bus Number 2048 (2GB MMCFG Range)\n"); : break; : case 1: : printk(BIOS_DEBUG, "Max Bus Number 1048 (1GB MMCFG range)\n"); : break; : case 2: : printk(BIOS_DEBUG, "Max Bus Number 512 (512MB MMCFG range)\n"); : break; : case 4: : printk(BIOS_DEBUG, "Max Bus Number 256 (256MB MMCFG range)\n"); : break; : case 5: : printk(BIOS_DEBUG, "Max Bus Number 127 (128MB MMCFG range)\n"); : break; : case 6: : printk(BIOS_DEBUG, "Max Bus Number 63 (64MB MMCFG range)\n"); : break; : default: : printk(BIOS_DEBUG, "Invalid Max Bus Number 0x%x\n", maxbusno); : break; : }
up to you, but this switch statement can be colapsed into: […]
This function is for debug purpose. It is removed.