Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43484 )
Change subject: Documentation: Revise "24 hours wait period" rules
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43484/1/Documentation/getting_start...
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/43484/1/Documentation/getting_start...
PS1, Line 53: build or boot issue
Is this just a build issue at coreboot.org, or maybe something that isn't tested at coreboot.org but is used somewhere else? This seems to be the heart of the unwritten rule that I got caught up in.
https://review.coreboot.org/c/coreboot/+/43484/1/Documentation/getting_start...
PS1, Line 66: * Do not +2 patches that you authored or own
Unrelated to this patch, but I think this section could be removed now. The author and committer's +2s are now ignored for merge purposes, so this no longer matters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620e48016a1ceda2ac43f26624ed21af01f6a0a5
Gerrit-Change-Number: 43484
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@scarletltd.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 Jul 2020 18:56:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment