Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37189 )
Change subject: soc/intel/cannonlake: Add IccMax limitation for CML U22
......................................................................
Patch Set 2:
Patch Set 2:
Open question:
Can we leverage SKL/KBL work of get_sku_icc_max()?
get_sku_icc_max() on SKY/KBL is do the same thing like the CML FSP (See Fsp mCpuVrOverrideTable at CometLakeSiliconPkg/Cpu/Library/Private/PeiCpuInitLib/CpuInitPreResetCpl.c).
I want to add a limitation for U22 CPU because no matter go through FSP VR override table or device tree, both have wrong IccMax[IA_CORE] configure.
Use FSP VR override table, IccMax[U42,U62] = 85A and IccMax[U22] = 35A ,but 85A is over the hatch VR design. Hatch is using 70A VR design.
Use device tree configure, IccMax[U22,U42,U62] = 70A, IccMax[U22] is over the EDS define 35A.
But it is a good reference code, I will use the same variable name at my next patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ae8feee3073884109e0d171511c5ac01064ffd7
Gerrit-Change-Number: 37189
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Harry Pan
harry.pan@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 26 Nov 2019 08:33:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment