14 Jul
2018
14 Jul
'18
5:28 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26233 )
Change subject: sdm845: Add GPIO API ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/26233/8/src/soc/qualcomm/sdm845/include/soc/... File src/soc/qualcomm/sdm845/include/soc/pinmux.h:
https://review.coreboot.org/#/c/26233/8/src/soc/qualcomm/sdm845/include/soc/... PS8, Line 24: #define PINMUX_CONSTANTS(index, tlmm, func1, func2, func3, \ Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/26233
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cef9dae2072da32cb0678efefeb8f0070cdde9c
Gerrit-Change-Number: 26233
Gerrit-PatchSet: 8
Gerrit-Owner: T.Michael Turney tturne@codeaurora.org
Gerrit-Reviewer: David Dai daidavid1@codeaurora.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: T Michael Turney mturney@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Sat, 14 Jul 2018 20:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No