Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47417 )
Change subject: mb/google/hatch: Configure IRQs as level triggered for HID over I2C
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/...
PS2, Line 167: ACPI_IRQ_WAKE_EDGE_LOW
was that forgotten? how can the two touchpads on the same gpio have different triggers?
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/...
PS2, Line 186: ACPI_IRQ_EDGE_LOW
same here as above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I320198d56131cf54e0f73227479f69968719b2a7
Gerrit-Change-Number: 47417
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 03 Jan 2021 11:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment