Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39337 )
Change subject: mb/google/volteer: change two gpio settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39337/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39337/1/src/mainboard/google/voltee...
PS1, Line 149: PAD_CFG_GPI_INT
Why is this GPI_INT? Why is it not using APIC?
I was bringing these changes over as-is from private repo. It was initially changed here:
https://chrome-internal-review.googlesource.com/c/chromeos/third_party/coreb...
Should it be APIC? Review owner said code was verified functional.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62da900d0b71139e55b52d06ec09ca25106f73cd
Gerrit-Change-Number: 39337
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 19:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment