HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31063 )
Change subject: nb/intel/i945: Fix typo on DMIBAR32(0x334) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31063/1/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/31063/1/src/northbridge/intel/i945/early_ini... PS1, Line 512: : : : : : lol
I've dropped all of them and still getting the same values tested on 945G-M4 + inteltool (with and without all of those lines): 0x0308: 0x00060018 0x0314: 0x00060000 0x0324: 0x00030018 0x0324: 0x00030018 0x0328: 0x00030000 0x0334: 0x00040008 0x0338: 0x00040000
I also have the same values with or without this patch, so for me, they are not WO but RO registers ...