Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41107 )
Change subject: mainboard(s): drop redundant entries from Makefiles
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41107/10/src/mainboard/facebook/fbg...
File src/mainboard/facebook/fbg1701/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41107/10/src/mainboard/facebook/fbg...
PS10, Line 14: ramstage-y += hda_verb.c
This removes the hds_verb.c from the build. It isn't included in another way. AZALIA_PLUGIN_SUPPORT is not set and the Braswell support doesn't pull it in either.
https://review.coreboot.org/c/coreboot/+/41107/10/src/mainboard/portwell/m10...
File src/mainboard/portwell/m107/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41107/10/src/mainboard/portwell/m10...
PS10, Line 6: ramstage-y += hda_verb.c
This removes the hds_verb.c from the build. It isn't included in another way. AZALIA_PLUGIN_SUPPORT is not set and the Braswell support doesn't pull it in either.
As a side item, wouldn't it be good to somehow document which files will be included implicitely from the mainboard directory? This makes creating a new mainboard directory a bit easier and prevents the inclusion of files that are not required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1961646c5ed4ae6a1308ce0e8e15792970da4e0d
Gerrit-Change-Number: 41107
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jun 2020 08:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment