[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick

[Simon Yang (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik.

Simon Yang has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email )

Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
......................................................................

Patch Set 6:

(2 comments)

File src/mainboard/google/brya/variants/anraggar/variant.c:

https://review.coreboot.org/c/coreboot/+/84098/comment/2f2c2f82_30a737d2?usp... :
PS5, Line 16: #define  TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_RESET	(2 << 6)
> why we need this ?

Done

https://review.coreboot.org/c/coreboot/+/84098/comment/f852a1b1_af9f9599?usp... :
PS5, Line 60: graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, (-1 & ~(TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK)),
            : 		TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET);
> ```graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, ~1, TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET);```

~1 is 0xfffffffe but I'd like to pass 0xffffff3f for clearing BIT7 and BIT6