Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48375/1/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48375/1/src/mainboard/clevo/cml-u/v... PS1, Line 184: # Address 0x8C: Decode 0xE00 - 0xEFF (AP/EC command) : register "gen3_dec" = "0x00fc0e01" : # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) : register "gen4_dec" = "0x00fc0f01" well, these were the values used for system76 ec; they need to be adapted anyways I guess (vendor uses different ones)