Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31290 )
Change subject: Revert "cpu/x86/mtrr: Fix sign overflow"
......................................................................
Patch Set 1:
Please introduce a better fix on x86_64.
Fix for what? you've never mentioned what you are trying to fix.
And it's not every obvious how a 21-bit number that doesn't
overflow on x86_32 overflows on x86_64.
If your change is really fixing something, it very likely hides
a problem somewhere else.
Also, please read the comment above the macros, it's supposed
to work not only in C.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12c9bfe40891ae3afbfda05f60a20b59e2954aed
Gerrit-Change-Number: 31290
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 09 Feb 2019 12:30:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment