[coreboot-gerrit] Change in coreboot[master]: soc/{apl,glk}: Allow to select the primary graphics device

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )

Change subject: soc/{apl,glk}: Allow to select the primary graphics device
......................................................................

Patch Set 33:

(1 comment)

File src/soc/intel/apollolake/chip.h:

https://review.coreboot.org/c/coreboot/+/39374/comment/f5c9434d_7e9a6de8 
PS17, Line 45: PRIMARY_AUTO = 0,
             : 	PRIMARY_IGD  = 2,
             : 	PRIMARY_PCI  = 3,
> If ONBOARD_VGA_IS_PRIMARY is set, coreboot/tianocore shows the splashscreen/setup menu only on the d […]

I have stumbled across this again...
First of all Angels is right, the comment in the FspmUpd.h does not match the implementation and hence is simply wrong. It turned out that we do have issues on an older GFX driver in Linux with this wrong setting.
So since this is Apollo Lake specific I would vote for a change to align with the FSP implementation and not the comment in the header file.
I can reach out to Intel to see if this can be resolved on the FSP side so that the comment is corrected.