Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 32:
(3 comments)
Patch Set 30: Code-Review+1
(5 comments)
Looks much better, thank you!
Apologies if my previous review sounded harsh, I did not intend it to be.
Feel free to reply to any comments :D
Nah, don't worry, you didn't sound harsh. I'm just intimidated by the whole system: this is my first time with Gerrit, Git, Coreboot, Tianocore, OSS, linux... I feel as if I were running the opposite way on a highway... but... nope :))
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.default:
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/cmos... PS23, Line 23: usb3_mode=Enable : usb3_preOS_drv=Enable : usb3_streams=Enable
I feel I might have expressed myself wrong. […]
I think these options should be present, because:
1. The original ASUS bios has them, so I figure out for a reason.
2. I've found these options useful to get the MRC working: I have multiple USB3 devices(pendrives,GbE,IoT,PXE dongles,cameras,etc) and some legacy devices work but others had USB3 incompatibilities with xHCI or streams... so I had to tweak these options in order to make devices to work properly. Without those options, I would never be able to use them. So, for the end user, I think it's good to have control on these options.
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... File src/mainboard/asus/p8z77-m_pro/cmos.layout:
https://review.coreboot.org/#/c/33328/22/src/mainboard/asus/p8z77-m_pro/cmos... PS22, Line 162: 7 16 1024M
I just copied the settings from the original Bios, but that's interesting! I'm gonna try to add valu […]
I've added a few more values in 32Mb increments and seems 1024M is working under linux Mint now! (tested with dmesg).
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/roms... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/23/src/mainboard/asus/p8z77-m_pro/roms... PS23, Line 72: /* : * Config several SuperIO ACPI things. : * See Nuvuton 6779D datasheet, section : * "21.10 Configuration Register->Logical Device A (ACPI)", : * page 340-341 : */
Not needed. […]
Tested a couple times. The 3VSBSW is **definitively** needed. Thanks for pointing it out tho ;)