build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41053 )
Change subject: Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I59d02dd42ae1d46d612e5a5d86b93aa5b37fb579 ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41053/1/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/41053/1/src/soc/intel/common/block/... PS1, Line 314: for(i = 0; i < gpio_communities; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41053/1/src/soc/intel/common/block/... PS1, Line 316: for(j = 0; j < comm->num_groups; j++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41053/1/src/soc/intel/common/block/... PS1, Line 319: printk(BIOS_DEBUG, "gpio_padcfg GPP_%s_%d [0x%02x, %02zd] ", group_curr->grp_name, k, comm->port, relative_pad_in_comm(comm, (comm_size+k))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/41053/1/src/soc/intel/common/block/... PS1, Line 322: printk(BIOS_DEBUG, " DW%d [0x%08x]", l,pad_conf); space required after that ',' (ctx:VxV)