Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0 ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/31416/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31416/8//COMMIT_MSG@10 PS8, Line 10: Also fix bios release value. what I said in this line in patch set 2.
https://review.coreboot.org/#/c/31416/8/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/8/src/arch/x86/smbios.c@386 PS8, Line 386: t->system_bios_minor_release = 9; I don't think it would be a good practice to hard-code it here. I guess a common header file where we'd have to change the version in a single place would do. Deriving it from the `git describe` string would be nice.