Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Tim Van Patten.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63613 )
Change subject: src/acpi/device.c: Early return in _ON if device already enabled
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63613/comment/e32726df_a38cf066
PS2, Line 7: .c
nit: you can drop the `.c`
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/63613/comment/9a2a014b_c8792b4a
PS2, Line 674:
Add: This avoids unnecessary delays while booting.
https://review.coreboot.org/c/coreboot/+/63613/comment/162ccfdf_8d9cbc34
PS2, Line 675:
Indent using 8 character width tabs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13aa41766555953b86eded4c72e3b317fe6db5c8
Gerrit-Change-Number: 63613
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 20:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment