[coreboot-gerrit] Change in coreboot[master]: pciexp: Add support for allocating PCI express hotplug resources

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )

Change subject: pciexp: Add support for allocating PCI express hotplug resources
......................................................................

Patch Set 3: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c 
File src/device/pciexp_device.c:

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... 
PS2, Line 485: 0x10
Does this handle BAR0? If yes you could use PCI_BASE_ADDRESS_0 instead of 0x10 her.

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... 
PS2, Line 494: 0x14
Same question here with BAR1

https://review.coreboot.org/c/coreboot/+/35946/2/src/include/device/device.h 
File src/include/device/device.h:

https://review.coreboot.org/c/coreboot/+/35946/2/src/include/device/device.h... 
PS2, Line 133: /* hotplug buses to allocate */
Maybe better: Number of hotplug buses to allocate?