Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66561 )
Change subject: cbfs/vboot: Adapt to new vb2_digest API
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
somehow this broke my google/vilboz. No console at all on the PSP verstage. […]
Sorry, wouldn't know why. PSP verstage should print some log output before this code even runs so it doesn't sound likely that this patch alone directly caused that kind of issue. (I assume you have one of the AMD/Google-internal devices with unlocked PSP? Because my understanding is that the PSP verstage binary is normally signed by AMD and cannot be replaced on retail devices. If you tried to do that that would explain why it doesn't boot, but then it should fail with any local build of coreboot, not related to this patch.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I287d8dac3c49ad7ea3e18a015874ce8d610ec67e
Gerrit-Change-Number: 66561
Gerrit-PatchSet: 10
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Comment-Date: Wed, 05 Oct 2022 23:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment