[coreboot-gerrit] Patch set updated for coreboot: 25d1fc9 mainboard/*/acpi/ide.asl: Serialize ACPI methods to avoid races.

5 Apr 2014

Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5458
-gerrit
commit 25d1fc901c35d3f0c3603aed99ffdedd4017fda1
Author: Edward O'Callaghan eocallaghan@alterapraxis.com
Date:   Sun Apr 6 01:57:42 2014 +1100
mainboard/*/acpi/ide.asl: Serialize ACPI methods to avoid races.
Serialize methods against the construction of same (named) objects by
    competing threads. See ACPICA BZ 909 for further details.
This change fixes issues that show up with the Ubuntu firmware test
    suite (fwts) ACPI table sanity checker.
Change-Id: I49e3050a2a5aece6f031122b0211c056938d1a89
    Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com
---
 src/mainboard/amd/inagua/acpi/ide.asl        | 8 ++++----
 src/mainboard/amd/persimmon/acpi/ide.asl     | 8 ++++----
 src/mainboard/amd/south_station/acpi/ide.asl | 8 ++++----
 src/mainboard/amd/torpedo/acpi/ide.asl       | 8 ++++----
 src/mainboard/amd/union_station/acpi/ide.asl | 8 ++++----
 src/mainboard/asus/m5a88-v/acpi/ide.asl      | 8 ++++----
 src/mainboard/supermicro/h8scm/acpi/ide.asl  | 8 ++++----
 7 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/src/mainboard/amd/inagua/acpi/ide.asl b/src/mainboard/amd/inagua/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/inagua/acpi/ide.asl
+++ b/src/mainboard/amd/inagua/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/persimmon/acpi/ide.asl b/src/mainboard/amd/persimmon/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/persimmon/acpi/ide.asl
+++ b/src/mainboard/amd/persimmon/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/south_station/acpi/ide.asl b/src/mainboard/amd/south_station/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/south_station/acpi/ide.asl
+++ b/src/mainboard/amd/south_station/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/torpedo/acpi/ide.asl b/src/mainboard/amd/torpedo/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/torpedo/acpi/ide.asl
+++ b/src/mainboard/amd/torpedo/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/amd/union_station/acpi/ide.asl b/src/mainboard/amd/union_station/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/amd/union_station/acpi/ide.asl
+++ b/src/mainboard/amd/union_station/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/asus/m5a88-v/acpi/ide.asl b/src/mainboard/asus/m5a88-v/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/asus/m5a88-v/acpi/ide.asl
+++ b/src/mainboard/asus/m5a88-v/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
diff --git a/src/mainboard/supermicro/h8scm/acpi/ide.asl b/src/mainboard/supermicro/h8scm/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/supermicro/h8scm/acpi/ide.asl
+++ b/src/mainboard/supermicro/h8scm/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */
-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,

    

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

[coreboot-gerrit] Patch set updated for coreboot: 25d1fc9 mainboard/*/acpi/ide.asl: Serialize ACPI methods to avoid races.