Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35296 )
Change subject: soc/amd/picasso: Refactor AOAC enabling
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35296/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35296/1//COMMIT_MSG@13
PS1, Line 13: Picasso's UARTs
Keep in mind this is primarily affecting the copy of stoneyridge code. […]
No need, your choice.
https://review.coreboot.org/c/coreboot/+/35296/1/src/soc/amd/picasso/southbr...
File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/35296/1/src/soc/amd/picasso/southbr...
PS1, Line 52: */
The comment is really meant to a caution to anyone who may try to add their UART to the aoac_devs li […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffc87f39ebe38394a56d41bb0940e9701fd05db9
Gerrit-Change-Number: 35296
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Sep 2019 17:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment