Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/31416/6/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/6/src/arch/x86/smbios.c@385
PS6, Line 385: =
Unrelated. That's the BIOS version, not the SMBIOS version.
ouch, should have looked at the lhs, too ._.
https://review.coreboot.org/#/c/31416/7/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/7/src/arch/x86/smbios.c@386
PS7, Line 386: t->system_bios_minor_release = 0;
Unrelated, and we are at 9 now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec35c8c66210f0ddc07a2ca6f976a1f8fc53037d
Gerrit-Change-Number: 31416
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 Feb 2019 09:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment